test: adapting the test to the new release #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_get_index_files_insitu.py
Outdated
Comment on lines
14
to
19
| self.output = execute_in_terminal(self.command, input=b"n\n") | ||
|
|
||
| assert ( | ||
| b"s3://mdl-native-01/native/INSITU_GLO_PHYBGCWAV_DISCRETE_MYNRT_013_030" | ||
| b"/cmems_obs-ins_glo_phybgcwav_mynrt_na_irr_202311/index_reference.txt" | ||
| in self.output.stdout | ||
| not in self.output.stdout |
There was a problem hiding this comment.
This we should either get rid of the test or find another example, because with the "not in" we are not testing anything
There was a problem hiding this comment.
Yep, cool, I see your point!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest release of the Marine Data Store, the tests needed to be updated. Maybe we could find a way to better standardise the procedure.