Fix tests not writing in a tmp_path #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitreb
force-pushed
the
remove-downloads-folder
branch
2 times, most recently
from
0e1299c to
34e2582
Compare
uriii3
approved these changes
May 14, 2024
uriii3
reviewed
May 14, 2024
tests/test_get_sync.py
Outdated
Comment on lines
9
to
16
| self.then_same_command_should_not_download() | ||
| self.when_I_delete_one_file() | ||
| self.when_I_delete_one_file(tmp_path) | ||
| self.then_same_command_with_sync_should_download_only_one_file() | ||
|
|
||
| def test_get_sync_delete(self): | ||
| self.when_I_get_some_native_files_with_sync() | ||
| def test_get_sync_delete(self, tmp_path): | ||
| self.when_I_get_some_native_files_with_sync(tmp_path) | ||
| self.when_I_add_a_file_locally() | ||
| self.then_command_sync_delete_should_propose_to_delete_it_and_delete_it() |
There was a problem hiding this comment.
the tmp_path is also missing here, no?
uriii3
approved these changes
May 14, 2024
tests/test_get_sync.py
Outdated
| def test_get_sync(self): | ||
| self.when_I_get_some_native_files_with_sync() | ||
| def test_get_sync(self, tmp_path): | ||
| self.when_I_get_some_native_files_with_sync(tmp_path) | ||
| self.then_same_command_should_not_download() |
There was a problem hiding this comment.
Suggested change
| self.then_same_command_should_not_download() | |
| self.then_same_command_should_not_download(tmp_path) |
tests/test_get_sync.py
Outdated
| self.then_same_command_should_not_download() | ||
| self.when_I_delete_one_file() | ||
| self.when_I_delete_one_file(tmp_path) | ||
| self.then_same_command_with_sync_should_download_only_one_file() |
There was a problem hiding this comment.
Suggested change
| self.then_same_command_with_sync_should_download_only_one_file() | |
| self.then_same_command_with_sync_should_download_only_one_file(tmp_path) |
tests/test_get_sync.py
Outdated
| def test_get_sync_delete(self): | ||
| self.when_I_get_some_native_files_with_sync() | ||
| def test_get_sync_delete(self, tmp_path): | ||
| self.when_I_get_some_native_files_with_sync(tmp_path) | ||
| self.when_I_add_a_file_locally() |
There was a problem hiding this comment.
Suggested change
| self.when_I_add_a_file_locally() | |
| self.when_I_add_a_file_locally(tmp_path) |
nitreb
force-pushed
the
remove-downloads-folder
branch
3 times, most recently
from
7edb5eb to
fcbf0c1
Compare
slim0
approved these changes
May 17, 2024
uriii3
force-pushed
the
remove-downloads-folder
branch
from
5a4f4e7 to
a0e3476
Compare
|
@renaudjester review this, it was a 's' that remained from quick typing... but no bigger problems I think. |
renaudjester
approved these changes
Jun 6, 2024
tests/test_get_sync.py
Outdated
| ] | ||
| self.output = execute_in_terminal(self.command) | ||
| print(self.output.stdout) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.