chore: get rid of pendulum for windows python3.13 users #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uriii3
approved these changes
Dec 11, 2024
Comment on lines
+406
to
+413
| min_time_datetime = temporal_parameters.start_datetime | ||
| min_time = None | ||
| if min_time_datetime: | ||
| min_time = min_time_datetime.timestamp() * 1e3 | ||
| max_time_datetime = temporal_parameters.end_datetime | ||
| max_time = None | ||
| if max_time_datetime: | ||
| max_time = max_time_datetime.timestamp() * 1e3 |
There was a problem hiding this comment.
so the typings read differently if the class is a pendulum or if it is a date time? quite cool, no? although I liked it best with pendulum.
| @@ -589,7 +590,7 @@ def _get_file_size_last_modified_and_etag( | |||
| ) | |||
| return ( | |||
| s3_object["ContentLength"], | |||
| pendulum.instance(s3_object["LastModified"]), | |||
| s3_object["LastModified"].astimezone(tz=UTC), | |||
There was a problem hiding this comment.
why put it here with a timezone?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix CMT-174
Some users are experiencing problems with pendulum with python3.13 and windows
📚 Documentation preview 📚: https://copernicusmarine--252.org.readthedocs.build/en/252/