chore: documentation domains & dependencies #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaudjester
reviewed
Dec 4, 2024
uriii3
commented
Dec 9, 2024
renaudjester
reviewed
Dec 9, 2024
Comment on lines
+38
to
+39
| [tool.poetry.group.dev.dependencies] | ||
| types-toml = "^0.10.8.20240310" |
There was a problem hiding this comment.
Ok so the problem is that now you have created a group for this, whereas there is a dev dependencies that exists already ([tool.poetry.dev-dependencies]) it could be coming from the difference of versions from the poetry you are using and the poetry used before to create the file
Anyway it would be nice to homogenize this: all dev deps in [tool.poetry.dev-dependencies] or all dev deps in [tool.poetry.dev-dependencies]
renaudjester
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing tickets CMT-158 and also CMT-156.
Mainly it is adding the domains that the toolbox uses (not anymore found by my in the code) and also the dependencies (see that we have no 'optional' dependencies, as it was something that is on our roadmap to be checked, how to separate the dependencies).
📚 Documentation preview 📚: https://copernicusmarine--245.org.readthedocs.build/en/245/