fix: minimum datetime should be in iso format #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaudjester
force-pushed
the
fix-format-min-datetime-when-retention-date
branch
from
bfef626 to
537654a
Compare
|
is this for CMT-100 ? |
uriii3
reviewed
Aug 28, 2024
| @@ -616,7 +616,7 @@ def _format_arco_data_metadata_producer_valid_start_date( | |||
| ).timestamp() | |||
| * 1000 | |||
| ) | |||
| return arco_data_metadata_producer_valid_start_date.split(".")[0] | |||
| return arco_data_metadata_producer_valid_start_date | |||
There was a problem hiding this comment.
okay, so basically when we are not returning it to a timestamp, it is okay to maintain (and they prefer it this way) the milliseconds and everything, no?
When are we sending it to timestamp and when not? In the code it appears isinstance(coordinates_info.get("min"), int) this but not sure what is the logic behind.
There was a problem hiding this comment.
I mean I was checking the ones that were supposed to be timestamps and the ones that weren't and all looked the same... what is the difference behind them?
uriii3
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.