Skip to content

Commit

Permalink
fix: fixing the tests to adapt to not having the attributes
Browse files Browse the repository at this point in the history
  • Loading branch information
uriii3 committed Jul 31, 2024
1 parent b4515df commit e6cdd55
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 35 deletions.
30 changes: 0 additions & 30 deletions tests/test_command_line_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -494,36 +494,6 @@ def check_subset_request_with_no_subsetting(self):
b"copernicusmarine get --dataset-id " + bytes(dataset_id, "utf-8")
) in self.output.stderr

def test_if_dataset_coordinate_valid_minmax_attributes_are_setted(
self, tmp_path
):
self.base_request_dict = {
"--dataset-id": "cmems_mod_glo_phy-so_anfc_0.083deg_P1D-m",
"--variable": "so",
"--start-datetime": "2024-01-01",
"--end-datetime": "2024-01-02",
"--minimum-latitude": "0.0",
"--maximum-latitude": "0.1",
"--minimum-longitude": "0.2",
"--maximum-longitude": "0.3",
"--minimum-depth": "0.0",
"--maximum-depth": "5.0",
"-f": "self.output.nc",
"--output-directory": tmp_path,
}

self.check_default_subset_request(self.GEOSERIES.subpath, tmp_path)

dataset_path = pathlib.Path(tmp_path) / "self.output.nc"
dataset = xarray.open_dataset(dataset_path)

assert dataset.latitude.attrs["valid_min"] >= 0
assert dataset.latitude.attrs["valid_max"] <= 0.1
assert dataset.depth.attrs["valid_min"] >= 0
assert dataset.depth.attrs["valid_max"] <= 5
assert dataset.time.attrs["valid_min"] == 648672
assert dataset.time.attrs["valid_max"] == 648696

def test_retention_period_works(self):
self.command = [
"copernicusmarine",
Expand Down
6 changes: 1 addition & 5 deletions tests/test_python_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ def test_open_dataset_with_retention_date(self):
password=os.getenv("COPERNICUSMARINE_SERVICE_PASSWORD"),
dataset_id="cmems_obs-oc_atl_bgc-plankton_nrt_l4-gapfree-multi-1km_P1D",
)
assert dataset.time.valid_min >= 45388
assert int(dataset.time.min().values) >= 1720735200000

def test_subset_modify_attr_for_depth(self):
dataset = open_dataset(
Expand Down Expand Up @@ -256,10 +256,6 @@ def test_subset_keeps_fillvalue_empty(self, tmp_path):
assert "_FillValue" not in subsetdata.time.attrs
assert "_FillValue" not in subsetdata.latitude.attrs
assert "_FillValue" not in subsetdata.depth.attrs
assert "valid_max" not in subsetdata.longitude.attrs
assert "valid_min" not in subsetdata.longitude.attrs
assert "valid_max" in subsetdata.latitude.attrs
assert "valid_max" in subsetdata.latitude.attrs
assert subsetdata.time.attrs["calendar"] == "gregorian"
assert subsetdata.time.attrs["units"] == "hours since 1950-01-01"

Expand Down

0 comments on commit e6cdd55

Please sign in to comment.