fix: filter precisely id and jump unknown dimensions (#239)

fix a bug where we would select too many datasets with `--dataset-id` option fix a bug where download calculation would fail for unknown dimensions
mercator-ocean · Dec 3, 2024 · 76b14ab · 76b14ab
1 parent 1c44b37
commit 76b14ab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/copernicusmarine/catalogue_parser/catalogue_parser.py b/copernicusmarine/catalogue_parser/catalogue_parser.py
@@ -87,6 +87,8 @@ def get_dataset_metadata(
                     dataset_json
                 )
             )
+            and get_version_and_part_from_full_dataset_id(dataset_item.id)[0]
+            == dataset_id
         ]
         return _parse_and_sort_dataset_items(dataset_items)
 

diff --git a/copernicusmarine/download_functions/utils.py b/copernicusmarine/download_functions/utils.py
@@ -279,11 +279,14 @@ def get_approximation_size_data_downloaded(
             if coordinate_name == "elevation":
                 coordinate_name = "depth"
                 temp_dataset["elevation"] = temp_dataset.elevation * (-1)
-            possible_coordinate_id = [
+            possible_coordinate_ids = [
                 coordinate_names
                 for coordinate_names in COORDINATES_LABEL.values()
                 if coordinate_name in coordinate_names
-            ][0]
+            ]
+            if not possible_coordinate_ids:
+                continue
+            possible_coordinate_id = possible_coordinate_ids[0]
             coordinates = [
                 coord
                 for coord in variable.coordinates