Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab ability range from wiki #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

and-zheng
Copy link

Abilities are only tracking target range right now, which directional casted abilities don't have. Added a line to grab ability range from the wiki. Consider making target range the same as cast range for directional casted abilities?

@DarkIntaqt
Copy link
Contributor

Hi, you may want to add this to the champion model file too : )

@jjmaldonis
Copy link
Member

Hey @and-zheng, can you please add the range to the Ability class as well? Without it, the code will break.

Added 'range' to the Ability class
@and-zheng
Copy link
Author

Just did, thanks for the notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants