feat: paid tunnels v1 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlottea98
force-pushed
the
lotta/dns-paid
branch
6 times, most recently
from
ed70484
to
4c13e94
Compare
charlottea98
commented
Jun 5, 2024
|
|
||
| let parsed: GetTunnelApiResponse = send_request(&client, &query_url, headers, None, "GET")?; | ||
| if parsed.result.is_empty() { | ||
| Ok(None) | ||
| } else { | ||
| Ok(Some(parsed.result[0].id.clone())) | ||
| // Check if there exists a tunnel with this name that hasn't been deleted |
There was a problem hiding this comment.
Deleted tunnels still show up in the response but has "deleted_at" set. Instead, it needs to find the tunnel name and where "deleted_at" is null
charlottea98
force-pushed
the
lotta/dns-paid
branch
3 times, most recently
from
e407642
to
eb7a4bb
Compare
jonaslindstr
approved these changes
Jun 10, 2024
linkup-cli/src/services/tunnel.rs
Outdated
| @@ -61,6 +54,13 @@ impl TunnelManager for RealTunnelManager { | |||
| } | |||
| } | |||
| } | |||
| fn is_tunnel_running(&self) -> Result<(), CheckErr> { | |||
| if !linkup_file_path(LINKUP_CLOUDFLARED_PID).exists() { | |||
There was a problem hiding this comment.
Condition can be reversed
charlottea98
force-pushed
the
lotta/dns-paid
branch
from
eb7a4bb
to
b746e60
Compare
ostenbom
approved these changes
Jun 10, 2024
clear-unused-dns.ts
Outdated
| console.error( | ||
| "Please set CLOUDFLARE_API_KEY and CLOUDFLARE_EMAIL environment variables" | ||
| "Run `menti localsecrets` to set the required environment variables" |
There was a problem hiding this comment.
This doesn't make sense in an open-source repo - but maybe we leave it / it's ok?
charlottea98
force-pushed
the
lotta/dns-paid
branch
from
b746e60
to
8bf2be7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested going from paid to free tunnel, and vice versa. Works smoothly for me at least 🤞
Some extra logging added that shows up when running
RUST_LOG=info cargo run -- start. There is more that can be done with logging but will leave that for the linear card DO-1495 "linkup: logger".Part of DO-1495
Resolves DO-1496