refactor: remove dependency on async-trait #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description With the release of Rust [1.75](https://blog.rust-lang.org/2023/12/28/Rust-1.75.0.html#async-fn-and-return-position-impl-trait-in-traits), the first round of stabilization of async in traits is out! This does come with its own [set of caveats](https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html#where-the-gaps-lie). But those seem to be mostly for public traits. The trait that we use it is, theoretically, public. But we intend it to be used by the other modules within the workspace, so it seems like it might be fine to move from the async-trait. It might be good to test on the worker scenario, since there might be something there that I'm missing, but it seems by the tests and checks that is all working.
ostenbom
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the release of Rust 1.75, the first round of stabilization of async in traits is out! This does come with its own set of caveats. But those seem to be mostly for public traits and issues with bounds. The trait that we use it is, theoretically, public. But we intend it to be used by the other modules within the workspace, so it seems like it might be fine to move from the async-trait.
It might be good to test on the worker scenario, since there might be something there that I'm missing, but it seems by the tests and checks that is all working.