Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: shuffle code and responsibility of LocalState #49

Merged
merged 8 commits into from
Nov 20, 2023
Merged

refactor: shuffle code and responsibility of LocalState #49

merged 8 commits into from
Nov 20, 2023

Commits on Nov 17, 2023

  1. refactor: stop using start methods on other commands 

    Achieve this by moving the state saving and loading responsibility to the LocalState itself
    @augustoccesar
    augustoccesar committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    120a86b View commit details
    Browse the repository at this point in the history

  2. refactor: create constants module and shuffle imports

    @augustoccesar
    augustoccesar committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    913e3e9 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. refactor: breakdown server config into local and remote

    @augustoccesar
    augustoccesar committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    7a38173 View commit details
    Browse the repository at this point in the history

  2. Revert "refactor: create constants module and shuffle imports" 

    This reverts commit 913e3e9.

# Conflicts:
#	linkup-cli/src/remote_local.rs
    @augustoccesar
    augustoccesar committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    9b272bc View commit details
    Browse the repository at this point in the history

  3. lint: apply Clippy suggestions

    @augustoccesar
    augustoccesar committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    9de9c40 View commit details
    Browse the repository at this point in the history

  4. refactor: ensure state save has a mutable reference to it

    @augustoccesar
    augustoccesar committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    fef3dcf View commit details
    Browse the repository at this point in the history

  5. refactor: remove unnecessary clones since now save use a reference

    @augustoccesar
    augustoccesar committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    ea2f792 View commit details
    Browse the repository at this point in the history

  6. refactor: change name of variable on mapping

    @augustoccesar
    augustoccesar committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    28055f6 View commit details
    Browse the repository at this point in the history