Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unnecessary Arc in SessionAllocator #38

Merged
merged 6 commits into from
Oct 23, 2023
Merged

refactor: remove unnecessary Arc in SessionAllocator #38

merged 6 commits into from
Oct 23, 2023

Commits on Oct 22, 2023

  1. refactor: move session allocator to a more functional approach 

    This also removes the need to have a wrapper struct that holds an Arc to the StringStore.
    @augustoccesar
    augustoccesar committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    7188988 View commit details
    Browse the repository at this point in the history

  2. refactor: move back to SessionAllocator as a Struct 

    Will keep the same structure to avoid changing the ergonomics around the feature.
    @augustoccesar
    augustoccesar committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    193ffb5 View commit details
    Browse the repository at this point in the history

  3. refactor: remove unnecessary Arc on SessionAllocator

    @augustoccesar
    augustoccesar committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    d190d99 View commit details
    Browse the repository at this point in the history

  4. fix: undo unnecessary method move

    @augustoccesar
    augustoccesar committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    9cea70e View commit details
    Browse the repository at this point in the history

  5. fix: correct variable name

    @augustoccesar
    augustoccesar committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    d2b47d9 View commit details
    Browse the repository at this point in the history

  6. refactor: move session allocator to the branch where is used

    @augustoccesar
    augustoccesar committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    f0cf5fa View commit details
    Browse the repository at this point in the history