Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new install-update-uninstall lifecycle #127

Merged

Conversation

augustoccesar
Copy link
Collaborator

@augustoccesar augustoccesar commented Dec 19, 2024

Changelog:

  • feat: add notice on commands run to let the user knows that there is a new version available.
  • feat: add a install.sh shell script as an alternative to installing with Homebrew.
  • feat: add update command.
    • It fetches the latest release from GitHub and replace the current binary with it.
  • feat: add uninstall command.
    • It stops all services and then remove the .linkupfolder. For the installation with install.sh, this should remove everything. For installations with Homebrew, the binary will not be removed. Maybe we should we also try to brew uninstall in here?
  • feat: allow to run stop command without having a .linkup folder set up.
  • chore: add .DS_Store to .gitignore.

@augustoccesar augustoccesar self-assigned this Dec 19, 2024
Copy link
Contributor

@ostenbom ostenbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!

linkup-cli/install.sh Show resolved Hide resolved
linkup-cli/src/update.rs Outdated Show resolved Hide resolved
@augustoccesar augustoccesar marked this pull request as ready for review December 23, 2024 08:55
@augustoccesar augustoccesar removed the wip label Dec 23, 2024
@augustoccesar augustoccesar merged commit d4c5f29 into main Jan 3, 2025
4 checks passed
@augustoccesar augustoccesar deleted the augustoccesar/new-install-uninstall-update-lifecycle branch January 3, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants