-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new install-update-uninstall lifecycle #127
Merged
augustoccesar
merged 20 commits into
main
from
augustoccesar/new-install-uninstall-update-lifecycle
Jan 3, 2025
Merged
feat: new install-update-uninstall lifecycle #127
augustoccesar
merged 20 commits into
main
from
augustoccesar/new-install-uninstall-update-lifecycle
Jan 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostenbom
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
…ifecycle # Conflicts: # linkup-cli/src/commands/stop.rs # linkup-cli/src/main.rs
augustoccesar
deleted the
augustoccesar/new-install-uninstall-update-lifecycle
branch
January 3, 2025 09:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
install.sh
shell script as an alternative to installing with Homebrew.update
command.uninstall
command..linkup
folder. For the installation withinstall.sh
, this should remove everything. For installations with Homebrew, the binary will not be removed. Maybe we should we also try tobrew uninstall
in here?stop
command without having a.linkup
folder set up..DS_Store
to.gitignore
.