feat: enforce services must be have at least one item

mentimeter · Nov 10, 2023 · 44812f2 · 44812f2
1 parent bdab3fe
commit 44812f2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/linkup-cli/src/main.rs b/linkup-cli/src/main.rs
@@ -200,7 +200,9 @@ enum Commands {
 
         #[arg(
             help = "<service>=<url> pairs to preview.",
-            value_parser = ValueParser::new(preview::parse_services_tuple)
+            value_parser = ValueParser::new(preview::parse_services_tuple),
+            required = true,
+            num_args = 1..,
         )]
         services: Vec<(String, String)>,
 

diff --git a/linkup-cli/src/preview.rs b/linkup-cli/src/preview.rs
@@ -10,11 +10,6 @@ pub fn preview(
     services: &[(String, String)],
     print_request: bool,
 ) -> Result<(), CliError> {
-    if services.is_empty() {
-        // TODO: Oliver don't care about this error handling (type)
-        return Err(CliError::BadConfig("No services specified".to_string()));
-    }
-
     let config_path = config_path(config)?;
     let input_config = get_config(&config_path)?;
     let create_preview_request: CreatePreviewRequest =