Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drop down reference filter widget #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Andries-Smit
Copy link
Contributor

@Andries-Smit Andries-Smit commented Nov 23, 2020

  • Add a new drop down reference selector filter, enables users to search over an association
    Implements feature request #8 and #13

@diego-antonelli
Copy link
Contributor

diego-antonelli commented Nov 24, 2020

Hi @Andries-Smit we appreciate this PR! Although for now the whole team is mobilized with features for Mx9, we will keep a task in our backlog and as soon as we can (probably FY2021/Q1) we will review and prioritize.

[WT-2988]

Thanks

@codecov-io
Copy link

Codecov Report

Merging #79 (aa207b7) into master (c3d41b5) will decrease coverage by 7.62%.
The diff coverage is 69.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   94.25%   86.63%   -7.63%     
==========================================
  Files          12       13       +1     
  Lines         331      389      +58     
  Branches       71       84      +13     
==========================================
+ Hits          312      337      +25     
- Misses         19       52      +33     
Impacted Files Coverage Δ
src/DropDownSort/components/DropDownSort.ts 87.50% <ø> (ø)
src/Pagination/components/PageSizeSelect.ts 78.37% <ø> (ø)
src/Pagination/utils/ContainerUtils.ts 29.78% <27.77%> (ø)
src/Pagination/components/BreakView.ts 100.00% <100.00%> (ø)
src/Pagination/components/PageButton.ts 100.00% <100.00%> (ø)
src/Pagination/components/PageNumberButton.ts 100.00% <100.00%> (ø)
src/Pagination/components/PageNumberView.ts 100.00% <100.00%> (ø)
src/Pagination/components/Pagination.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 797c42f...aa207b7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants