-
Notifications
You must be signed in to change notification settings - Fork 741
Replace image with code snippet: Build Microflow Actions with Java #9112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Karuna,
I have noted a couple of questions, but if the developer has created this and the Java does what it is supposed to do then they aren't important.
Generally a great improvement. Thanks.
|
||
{{< figure src="/attachments/howto/extensibility/howto-connector-kit/join_objects_javacode.png" alt="Java implementation join object" class="no-border" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete all the images now that you aren't using them any more. It makes the PR more complete and clearer about what the intention is.
(Although there is a monthly job which will do that automatically if you miss any)
this.InitializationMicroflow = _initializationMicroflow; | ||
this.ListSize = _listSize; | ||
} | ||
``` | ||
|
||
The `executeAction` method is where all the magic happens: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where all the magic happens
Looks like this document could do with a thorough review as well as I'm not sure whether we should be saying this.
But we can pick that up later - and perhaps give it to Quinn to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will continue to do the proofreading for the rest of the doc in this same PR.
return objects.get(0); | ||
|
||
} catch (Exception e) { | ||
throw new CoreException("Failed to import JSON string: " + e.getMessage(), e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be different from the original image - but if it runs correctly for the dev, then great.
No description provided.