Implement deployments create #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustand2
force-pushed
the
master
branch
5 times, most recently
from
cc2949c
to
065665e
Compare
|
Merging these commits will result in the following changelog entries: Changelogsmender-cli (master)New changes in mender-cli since master: Features
|
rustand2
force-pushed
the
master
branch
8 times, most recently
from
f41204e
to
be04eb4
Compare
Added a new command to create deployments. Changelog: title Ticket: none Signed-off-by: Lars Rustand <[email protected]>
kacf
requested changes
Oct 9, 2023
Comment on lines
+60
to
+71
| if len(args) > 1 { | ||
| deploymentName = args[0] | ||
| } | ||
|
|
||
| artifactID := "" | ||
| if len(args) > 2 { | ||
| artifactID = args[1] | ||
| } | ||
|
|
||
| deviceList := "" | ||
| if len(args) >= 3 { | ||
| deviceList = args[2] |
There was a problem hiding this comment.
I think having mandatory ordered arguments, with no flags, is not good style, and difficult to change or adapt later. There should be --deployment-name <NAME> and -n <NAME> type flags for all of these I think. Take a look at how the other commands are adding arguments.
| ) | ||
|
|
||
| var deploymentCreateCmd = &cobra.Command{ | ||
| Use: "create [flags] DEPLOYMENT_NAME ARTIFACT_NAME DEVICE_LIST", |
There was a problem hiding this comment.
This should be documented better, especially device list. Like where it can be found, and whether the list is comma separated or not. I know this comes from the API, but people don't typically look there.
|
Any news on this @rustand2? Is there something we can help with putting this forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a command to create new deployments from mender-cli. I'm sorry if this is rather rough, but I've never used go before. Currently the only deployment command I implemented was
create, and there is limited handling of wrong arguments. Currently the device list needs to be passed as a raw json list by the user which is probably not an acceptable way to do it. I would appreciate any help to make this better from someone more proficient in go.