Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for batch operations in electrum RPC #98

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

junderw
Copy link
Member

@junderw junderw commented Jul 27, 2024

Fixes #77

Instead of sending one object per line { ... }.

The client can send an array of objects [{ ... }, { ... }, { ... }, { ... }] and the responses will be sent back in batches.

@junderw junderw requested a review from mononaut July 27, 2024 07:37
@junderw
Copy link
Member Author

junderw commented Jul 27, 2024

Return early with errors was messing things up. So instead, every error turns into a json Value.

@mononaut if you can think of anything else that needs fixing, let me know.

Copy link
Contributor

@mononaut mononaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ [50a6cd7]

@softsimon softsimon merged commit bffba5a into mempool Aug 26, 2024
7 checks passed
@softsimon softsimon deleted the junderw/batch-rpc branch August 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support batched JSON-RPC requests
3 participants