Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rust module build directory loop #478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dintorf
Copy link

@dintorf dintorf commented Jun 3, 2024

Description

Fixed the build_and_copy_rust_modules directory loop to properly handle the list of projects.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Issue 477

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@antepusic antepusic requested a review from gitbuda June 3, 2024 20:47
@gitbuda gitbuda added the lang: rust Issue on Rust codebase label Jun 5, 2024
@Josipmrden
Copy link
Collaborator

Funny, I fixed that today and only then I saw this 😂
Mine is #483
Will be ready for MAGE v1.18!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: rust Issue on Rust codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants