Skip to content

Add esp32s3_devkitc support #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ jobs:
-- \
-DCONFIG_MEMFAULT_PROJECT_KEY=\"1234\"

west build --sysbuild \
--pristine=always \
--board=esp32s3_devkitc/esp32s3/procpu zephyr-esp32-example \
-- \
-DCONFIG_MEMFAULT_PROJECT_KEY=\"1234\"

west build --sysbuild \
--pristine=always \
--board=esp32c3_devkitm zephyr-esp32-example \
Expand Down
10 changes: 0 additions & 10 deletions boards/esp32c3_devkitm.conf
Original file line number Diff line number Diff line change
@@ -1,16 +1,6 @@
CONFIG_WIFI=y

# For now, capture smaller coredumps to fit available RAM
CONFIG_MEMFAULT_RAM_BACKED_COREDUMP_SIZE=1024

CONFIG_NETWORKING=y
CONFIG_NET_L2_ETHERNET=y

CONFIG_NET_IPV6=n
CONFIG_NET_IPV4=y
CONFIG_NET_DHCPV4=y
CONFIG_ESP32_WIFI_STA_AUTO_DHCPV4=y

# Override selections from prj.conf to save space on this chip
CONFIG_LOG=y
CONFIG_NET_LOG=n
Expand Down
5 changes: 5 additions & 0 deletions boards/esp32s3_devkitc_esp32s3_procpu.conf
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
CONFIG_NET_LOG=y

# Enable external SPI RAM
CONFIG_SPI=y
CONFIG_ESP_SPIRAM=y
13 changes: 13 additions & 0 deletions boards/esp32s3_devkitc_esp32s3_procpu.overlay
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
/*
* Copyright (c) 2023 Espressif Systems (Shanghai) Co., Ltd.
*
* SPDX-License-Identifier: Apache-2.0
*/

&wifi {
status = "okay";
};

&coretemp {
status = "okay";
};
10 changes: 0 additions & 10 deletions boards/esp32s3_devkitm_esp32s3_procpu.conf
Original file line number Diff line number Diff line change
@@ -1,11 +1 @@
CONFIG_WIFI=y

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, most of these are duplicates already!

CONFIG_NETWORKING=y
CONFIG_NET_L2_ETHERNET=y

CONFIG_NET_IPV6=n
CONFIG_NET_IPV4=y
CONFIG_NET_DHCPV4=y
CONFIG_ESP32_WIFI_STA_AUTO_DHCPV4=y

CONFIG_NET_LOG=y
3 changes: 3 additions & 0 deletions prj.conf
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ CONFIG_WIFI=y
CONFIG_WIFI_LOG_LEVEL_ERR=y
CONFIG_NET_L2_WIFI_SHELL=y

CONFIG_NET_L2_ETHERNET=y
CONFIG_ESP32_WIFI_STA_AUTO_DHCPV4=y

# Memfault configuration
CONFIG_MEMFAULT=y
CONFIG_MEMFAULT_LOGGING_ENABLE=y
Expand Down
Loading