chore(wifi): workaround missing Kconfig check on latest Zephyr #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gminn
changed the title
gminn
force-pushed
the
gminn/fix-zephyr-latest-build
branch
from
af9ef4b to
197962c
Compare
### Summary The changes in recent upstream commit[^1] in the ESP WIFI driver added a header without checking that the correct Kconfig dependency was enabled. Add the missing Kconfig dependency to work around this. [^1] zephyrproject-rtos/zephyr@91b688a#diff-4e692c27c1090ab494a23007de38cb2539cfac21b893099a24236abedf5c9c90 ### Test Plan Built successfuly with zephyr `main` branch.
gminn
force-pushed
the
gminn/fix-zephyr-latest-build
branch
from
197962c to
1ec396b
Compare
gminn
changed the title
gminn
changed the title
|
3.7.0 build is failing in because we are missing the header added in this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The changes in a recent upstream commit in the ESP WIFI driver added
a header without checking that the correct Kconfig dependency was
enabled 1. Add the missing Kconfig dependency to work around this for now.
It is already being fixed in zephyrproject-rtos/zephyr#78180 so this
commit will be reverted when that merges.
Test Plan
Built successfuly with zephyr
mainbranch.Footnotes
https://github.com/zephyrproject-rtos/zephyr/commit/91b688a666aedbce906d2cd126f85048ab09c7c3#diff-4e692c27c1090ab494a23007de38cb2539cfac21b893099a24236abedf5c9c90 ↩