Skip to content

fix: Avoid registering mappers for unselected streams #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ReubenFrankel
Copy link
Contributor

@ReubenFrankel ReubenFrankel commented May 19, 2025

Summary by Sourcery

Bug Fixes:

  • Skip registering raw stream schemas for unselected streams in register_raw_streams_from_catalog.

📚 Documentation preview 📚: https://meltano-sdk--3046.org.readthedocs.build/en/3046/

Copy link
Contributor

sourcery-ai bot commented May 19, 2025

Reviewer's Guide

Update register_raw_streams_from_catalog to consult each stream’s selection metadata and skip unselected streams, preventing unnecessary mapper/schema registration.

File-Level Changes

Change Details Files
Skip registration of raw streams for unselected catalog entries
  • Resolve selection mask using catalog_entry.metadata.resolve_selection()
  • Add conditional check to continue the loop when mask[()] is False
  • Exclude unselected streams from raw stream schema registration
singer_sdk/mapper.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (d376b62) to head (5c179e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3046      +/-   ##
==========================================
- Coverage   91.64%   91.36%   -0.29%     
==========================================
  Files          62       62              
  Lines        5315     5315              
  Branches      686      686              
==========================================
- Hits         4871     4856      -15     
- Misses        312      329      +17     
+ Partials      132      130       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Performance Report

Merging #3046 will not alter performance

Comparing ReubenFrankel:1942-bug-tap-fails-if-stream-maps-config-contains-a-key-for-an-unselected-stream (5c179e7) with main (d376b62)

Summary

✅ 8 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant