Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Safely compare UUID replication keys with state bookmarks #2756

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 11, 2024

A backport of #2755 for v0.42.


📚 Documentation preview 📚: https://meltano-sdk--2756.org.readthedocs.build/en/2756/

Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #2756 will not alter performance

Comparing 2755-backport (9c80131) with v0.42 (3ebd4dd)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.74%. Comparing base (3ebd4dd) to head (9c80131).
Report is 1 commits behind head on v0.42.

Additional details and impacted files
@@           Coverage Diff           @@
##            v0.42    #2756   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files          62       62           
  Lines        5099     5102    +3     
  Branches      658      659    +1     
=======================================
+ Hits         4627     4630    +3     
  Misses        330      330           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 11, 2024 20:09
@edgarrmondragon edgarrmondragon merged commit e264392 into v0.42 Nov 11, 2024
40 checks passed
@edgarrmondragon edgarrmondragon deleted the 2755-backport branch November 11, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant