Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mappers): Stream name can now be accessed in stream maps #2699

Conversation

holly-evans
Copy link
Contributor

@holly-evans holly-evans commented Oct 3, 2024

Description

Allow users to reference the stream name or alias in stream maps under a special key, similar to record and config:

{
    "stream_maps": {
        "*": {
            "source_table": "__stream_name__",
            "source_data": "record",
        }
    }
}

Add two tests for existing functionality of self and _ keys

Related Issues


📚 Documentation preview 📚: https://meltano-sdk--2699.org.readthedocs.build/en/2699/

Copy link

codspeed-hq bot commented Oct 3, 2024

CodSpeed Performance Report

Merging #2699 will not alter performance

Comparing holly-evans:issue-2283-use-stream-name-in-stream-map-context (e03465c) with main (c2f5a22)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.55%. Comparing base (c2f5a22) to head (e03465c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2699   +/-   ##
=======================================
  Coverage   90.55%   90.55%           
=======================================
  Files          62       62           
  Lines        4997     4997           
  Branches      637      637           
=======================================
  Hits         4525     4525           
  Misses        328      328           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon changed the title feat(mappers): access stream name in stream map context feat(mappers): Stream name can now be accessed in stream maps Oct 3, 2024
@edgarrmondragon edgarrmondragon added this to the v0.42.0 milestone Oct 4, 2024
@edgarrmondragon edgarrmondragon requested review from a team as code owners October 10, 2024 00:04
@edgarrmondragon
Copy link
Collaborator

Thanks @holly-evans!

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Oct 10, 2024
Merged via the queue into meltano:main with commit 702c0db Oct 10, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support using the stream name or alias in the context of a stream map
2 participants