Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mapped datetime values are now typed as date-time strings in the schema message #2665

Merged
merged 4 commits into from
Sep 11, 2024
Merged

fix: Mapped datetime values are now typed as date-time strings in the schema message #2665

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ac8918
check for date and datetime in stream_maps
Sep 4, 2024
4e09c9f
expr.endswith(".date()")
Sep 4, 2024
9f03dc9
Merge branch 'main' into 1695_bug_fix_datetype_stream_maps
gregkoutsimp Sep 11, 2024
3281177
Update mapper.py
edgarrmondragon Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion singer_sdk/mapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ def _eval(

return result

def _eval_type(
def _eval_type( # noqa: PLR0911
self,
expr: str,
default: th.JSONTypeHelper | None = None,
Expand Down Expand Up @@ -398,6 +398,12 @@ def _eval_type(
if expr.startswith("bool("):
return th.BooleanType()

if expr.startswith("datetime.date") or expr.endswith(".date()"):
return th.DateType()

if expr.startswith("datetime.datetime"):
return th.DateTimeType()

return th.StringType() if expr[0] == "'" and expr[-1] == "'" else default

def _init_functions_and_schema( # noqa: PLR0912, PLR0915, C901
Expand Down
Loading