-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SQLTap connector instance shared with streams #1861
Merged
edgarrmondragon
merged 19 commits into
meltano:main
from
BuzzCutNorman:1733-tap-level-connector-instance-shared-with-streams
Aug 17, 2023
Merged
feat: SQLTap connector instance shared with streams #1861
edgarrmondragon
merged 19 commits into
meltano:main
from
BuzzCutNorman:1733-tap-level-connector-instance-shared-with-streams
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-tap-level-connector-instance-shared-with-streams
Codecov Report
@@ Coverage Diff @@
## main #1861 +/- ##
==========================================
+ Coverage 86.95% 86.97% +0.01%
==========================================
Files 59 59
Lines 5084 5090 +6
Branches 823 824 +1
==========================================
+ Hits 4421 4427 +6
Misses 466 466
Partials 197 197
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Just wanted to check in on this PR. Thanks |
I'm gonna give this a try with MeltanoLabs/tap-postgres |
edgarrmondragon
approved these changes
Aug 17, 2023
Thanks @BuzzCutNorman! |
BuzzCutNorman
deleted the
1733-tap-level-connector-instance-shared-with-streams
branch
November 28, 2023 15:11
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a variable
_tap_connector
toSQLTap
to house an instance of thedefault_stream_class.connector_class
and a property to access it. Thecatalog_dict
anddiscover_streams
methods were updated to utilize the new property.Closes #1773
📚 Documentation preview 📚: https://meltano-sdk--1861.org.readthedocs.build/en/1861/