Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: push _MAX_RECORDS_LIMIT down into SQL #1111

Merged
merged 2 commits into from
Oct 26, 2022
Merged

fix: push _MAX_RECORDS_LIMIT down into SQL #1111

merged 2 commits into from
Oct 26, 2022

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Oct 26, 2022 •
edited
Loading

@kgpayne kgpayne changed the title push _MAX_RECORDS_LIMIT down into SQL fix: push _MAX_RECORDS_LIMIT down into SQL Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022 •
edited
Loading

Codecov Report

Merging #1111 (731e03a) into main (1d1ba19) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1111   +/-   ##
=======================================
  Coverage   83.46%   83.47%           
=======================================
  Files          42       42           
  Lines        3853     3855    +2     
  Branches      657      658    +1     
=======================================
+ Hits         3216     3218    +2     
  Misses        472      472           
  Partials      165      165
Impacted Files Coverage Δ
singer_sdk/streams/sql.py 93.44% <100.00%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgpayne
Copy link
Contributor Author

kgpayne commented Oct 26, 2022

@aaronsteers @edgarrmondragon this solves the performance issue I was seeing here (making automated tests for tap-snowflake pass 🚀) however, in the same vein as min and max constraints (discussed here) I think the limit should also be passed in the get_records and get_batches signatures. Have added a note to the min/max discussion 🙂

aaronsteers
aaronsteers approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kgpayne kgpayne marked this pull request as ready for review October 26, 2022 14:50
@kgpayne kgpayne merged commit 0122d47 into main Oct 26, 2022
@kgpayne kgpayne deleted the kgpayne/issue1110 branch October 26, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers aaronsteers approved these changes

@edgarrmondragon edgarrmondragon Awaiting requested review from edgarrmondragon edgarrmondragon is a code owner

@cjohnhanson cjohnhanson Awaiting requested review from cjohnhanson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: SQLStreams do not push _MAX_RECORDS_LIMIT down to SQL query
2 participants
@kgpayne @aaronsteers