fix: Null type is now correctly appended as {"type": "null"} to `on…

…eOf` types (#2252)
meltano · Feb 19, 2024 · da62f9a · da62f9a
1 parent 5e02dac
commit da62f9a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/singer_sdk/helpers/_typing.py b/singer_sdk/helpers/_typing.py
@@ -60,7 +60,7 @@ def append_type(type_dict: dict, new_type: str) -> dict:
         return result
 
     if "oneOf" in result:
-        result["oneOf"].append(new_type)
+        result["oneOf"].append({"type": new_type})
         return result
 
     if "type" in result:

diff --git a/tests/core/test_typing.py b/tests/core/test_typing.py
@@ -341,7 +341,7 @@ def test_to_sql_type(jsonschema_type, expected):
         ),
         pytest.param(
             {"oneOf": [{"type": "integer"}, {"type": "number"}]},
-            {"oneOf": [{"type": "integer"}, {"type": "number"}, "null"]},
+            {"oneOf": [{"type": "integer"}, {"type": "number"}, {"type": "null"}]},
             id="oneOf",
         ),
     ],