Skip to content

Commit

Permalink
chore: Bump duckdb test dependency (#2145)
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon authored Jan 11, 2024
1 parent 2fe3e8d commit 1385aeb
Show file tree
Hide file tree
Showing 4 changed files with 97 additions and 107 deletions.
10 changes: 0 additions & 10 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,6 @@
]


def _clean_py312_deps(session: Session, dependencies: list[str]) -> None:
"""Clean dependencies for Python 3.12."""
if session.python == "3.12":
dependencies.remove("duckdb")
dependencies.remove("duckdb-engine")


@session(python=main_python_version)
def mypy(session: Session) -> None:
"""Check types with mypy."""
Expand All @@ -84,7 +77,6 @@ def mypy(session: Session) -> None:
@session(python=python_versions)
def tests(session: Session) -> None:
"""Execute pytest tests and compute coverage."""
_clean_py312_deps(session, test_dependencies)
session.install(".[s3,parquet]")
session.install(*test_dependencies)

Expand Down Expand Up @@ -118,7 +110,6 @@ def tests(session: Session) -> None:
@session(python=main_python_version)
def benches(session: Session) -> None:
"""Run benchmarks."""
_clean_py312_deps(session, test_dependencies)
session.install(".[s3]")
session.install(*test_dependencies)
sqlalchemy_version = os.environ.get("SQLALCHEMY_VERSION")
Expand All @@ -141,7 +132,6 @@ def update_snapshots(session: Session) -> None:
"""Update pytest snapshots."""
args = session.posargs or ["-m", "snapshot"]

_clean_py312_deps(session, test_dependencies)
session.install(".")
session.install(*test_dependencies)
session.run("pytest", "--snapshot-update", *args)
Expand Down
Loading

0 comments on commit 1385aeb

Please sign in to comment.