Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove catalog_uri setting from tap-iceberg #1830

Merged
merged 5 commits into from
Sep 13, 2024
Merged

fix: Remove catalog_uri setting from tap-iceberg #1830

merged 5 commits into from
Sep 13, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 9, 2024 •
edited
Loading

@netlify Netlify
Copy link

netlify bot commented Sep 9, 2024 •
edited
Loading

✅ Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit b48a9a0
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/66e47e5d7739c50008e99fbd
😎 Deploy Preview https://deploy-preview-1830--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tayloramurphy
Copy link
Collaborator

FYI @BTheunissen - are there any other settings that need updating?

@edgarrmondragon
Copy link
Collaborator Author

Thanks for the ✔️ @BTheunissen!

@edgarrmondragon edgarrmondragon merged commit d7f7156 into main Sep 13, 2024
12 of 13 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/remove-tap-iceberg-catalog-uri branch September 13, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BTheunissen BTheunissen BTheunissen approved these changes

@tayloramurphy tayloramurphy Awaiting requested review from tayloramurphy tayloramurphy is a code owner

@pnadolny13 pnadolny13 Awaiting requested review from pnadolny13 pnadolny13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarrmondragon @tayloramurphy @BTheunissen