add searching for latest revs and download #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bollenn
commented
May 30, 2017
bollenn
commented
- Add some functions to search for latest modified file or latest "version"
- Add function to download a file
bollenn
force-pushed
the
add_search_and_download
branch
from
31b7016 to
90744dd
Compare
rt_factory/rt_factory.py
Outdated
|
|
||
| def get_link_to_last_version(self, repo, path): | ||
| """ Searches for artifacts with the latest value in the "version" property. Only artifacts | ||
| with a "version" property expressly defined in lower case will be taken into account. |
There was a problem hiding this comment.
What do you mean by this? Will it give issue with version numbers like "V1.0.0" or "1.4.8-BETA"?
There was a problem hiding this comment.
no, you need to set the "version" property... with this exact name
There was a problem hiding this comment.
btw, this is a copy paste from Artifactory API doc 😆
There was a problem hiding this comment.
@ptillemans Out of curiosity: Artifactory does not provide a more intelligent way of getting the latest versions? As it knows the different types of the repositories (pypi, nuget, debian,...) I would expect it to be able to know based what the latest version is without needing to add an extra version property?
rt_factory/rt_factory.py
Outdated
| url (str): Url to the file to be downloaded. | ||
| path_to_file (str): Path + filename to be used for downloading the file. | ||
| """ | ||
| r = requests.get(url, stream=True) |
rt_factory/rt_factory.py
Outdated
| path_to_file (str): Path + filename to be used for downloading the file. | ||
| """ | ||
| r = requests.get(url, stream=True) | ||
| with open(path_to_file, 'wb') as f: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.