Skip to content

Commit

Permalink
Add support for php8 (#32)
Browse files Browse the repository at this point in the history
* Add support for php8

This will enable php-speller to be installed with php8.
Also change the build on travis to add coverage for 7.4 and a new step on php8

* Remove getMessage from ExceptionInterface

Remove this message, as it is not needed since it is coming from `Throwable`. Since PHP8 there needs to be a return type given or the declaration would fail.

* Update CHANGELOG.md
  • Loading branch information
icanhazstring authored Mar 15, 2021
1 parent ad6e2b8 commit 85841c9
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@ php:
- 7.2
- 7.3
- 7.4
- 8.0

matrix:
fast_finish: true
include:
- php: 7.2
- php: 7.4
env:
- PHPUNIT_FLAGS="--coverage-clover build/logs/clover.xml"

Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 2.1.4 - 2021-03-15
### Changed
- Add support for PHP 8
### Removed
- Removed `getMessage` from `PhpSpellerException` as it already declared from `Throwable`

## 2.1.3 - 2020-09-23
### Fixed
- Fix incorrect escaping of hunspell command (#29)
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
}
],
"require": {
"php": "^7.1",
"php": ">=7.1",
"symfony/process": "^4.4 || ^5.0",
"ext-iconv": "*",
"ext-dom": "*",
Expand Down
4 changes: 0 additions & 4 deletions src/Exception/PhpSpellerException.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,4 @@
*/
interface PhpSpellerException extends Throwable
{
/**
* @return string
*/
public function getMessage();
}

0 comments on commit 85841c9

Please sign in to comment.