Make doc-comments consistently be doc-comments #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meili-bors bot
added a commit
that referenced
this pull request
Jan 27, 2025
639: Make doc-comments consistently be doc-comments r=irevoire a=CommanderStorm # Pull Request ## Related issue no related issue, as just a docs change ## What does this PR do? - Make doc-comments consistently be doc-comments - Also fixes a few links which `cargo doc` complained about ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Frank Elsinga <[email protected]>
|
Build failed: |
CommanderStorm
commented
Jan 27, 2025
| @@ -29,7 +29,7 @@ pub fn generate_tenant_token( | |||
| return Err(Error::InvalidUuid4Version); | |||
| } | |||
|
|
|||
| if expires_at.map_or(false, |expires_at| OffsetDateTime::now_utc() > expires_at) { | |||
| if expires_at.is_some_and(|expires_at| OffsetDateTime::now_utc() > expires_at) { | |||
There was a problem hiding this comment.
Same (unrelated) linting issue as here:
|
sorry for the missed approach on this one. Did not think to run clippy (only |
curquiza
added
documentation
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
no related issue, as just a docs change
What does this PR do?
cargo doccomplained aboutPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!