Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat support retry pattern on status code 502, 503, 504 #581

Merged
merged 8 commits into from
Oct 2, 2024

Conversation

Ja7ad
Copy link
Collaborator

@Ja7ad Ja7ad commented Oct 2, 2024

Pull Request

Related issue

Fixes #569

What does this PR do?

  • Add retry pattern logic in client as default can manage retry pattern via options.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Ja7ad Ja7ad requested a review from curquiza October 2, 2024 10:42
@Ja7ad Ja7ad changed the title Feat/retry pattern Feat support retry pattern on status code 502, 503, 504 Oct 2, 2024
@Ja7ad Ja7ad added the enhancement New feature or request label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.92%. Comparing base (92b1ab7) to head (1f0b432).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
+ Coverage   87.65%   87.92%   +0.26%     
==========================================
  Files          13       13              
  Lines        2293     2344      +51     
==========================================
+ Hits         2010     2061      +51     
  Misses        172      172              
  Partials      111      111              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

options.go Show resolved Hide resolved
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about documentation.

I will merge after this 👌

README.md Outdated Show resolved Hide resolved
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiice

bors merge

Copy link
Contributor

meili-bors bot commented Oct 2, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 4f9f232 into meilisearch:main Oct 2, 2024
6 checks passed
meili-bors bot added a commit that referenced this pull request Oct 28, 2024
584: Update version for the next release (v0.29.0) r=brunoocasali a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-go to a new version: "v0.29.0"

--- Changelogs 👇 ---

## ⚠️ Breaking changes (experimental feature)

* `embedder` is now mandatory everywhere - Ensure compatibility with [Meilisearch v1.11](https://github.com/meilisearch/meilisearch/releases/tag/v1.11.0) by `@/Kerollmops`

## 🚀 Enhancements

* Add Embedder.URL (#568) `@/polyfloyd`
* Add multi-search federation (#563) `@/polyfloyd`
* Feat support content encoding  (#570) `@/Ja7ad`
* Support experimental manager (#572) `@/A7bari`
* Feat Language settings & search parameter (#580) `@J/a7ad`
* Feat support retry pattern on status code 502, 503, 504 (#581) `@/Ja7ad`

Thanks again to `@/A7bari,` `@/Ja7ad,` `@/Kerollmops`  and `@/polyfloyd!` 🎉



Co-authored-by: meili-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support retry pattern on status code 502, 503, 504
2 participants