fix bug finding focus in stack with only one slice #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching and fixing, @ieivanov. I followed your refactoring suggestion, and I moved the single-slice check to the top level so that it can return 0 directly. |
talonchandler
approved these changes
Mar 18, 2024
|
Looks good! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing bug related to focus finding in stack with only one slice.
in_focus_index=0should be returned byfocus_from_transverse_band, not_check_focus_inputs._check_focus_inputscould also be refactored into two functions that 1. check the inputs and 2. determine the correct optimization function. This will remove possible confusion on_check_focus_inputsreturning a callable.