Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes on correlation of PCA and UMAP components to computed_feature script #159

Merged
merged 15 commits into from
Sep 27, 2024

Conversation

Soorya19Pradeep
Copy link
Contributor

I am adding small bug fixes on the script for computing the correlation between PCA and UMAP features and the computed features on this branch.

@ziw-liu
Copy link
Collaborator

ziw-liu commented Sep 11, 2024

@Soorya19Pradeep do you expect more work on this branch?

@ziw-liu ziw-liu added bug Something isn't working representation Representation learning (SSL) labels Sep 11, 2024
@Soorya19Pradeep
Copy link
Contributor Author

@Soorya19Pradeep do you expect more work on this branch?

Yes @ziw-liu . I am going through, correcting the feature extraction methods

@Soorya19Pradeep Soorya19Pradeep marked this pull request as ready for review September 18, 2024 20:57
@Soorya19Pradeep
Copy link
Contributor Author

@ziw-liu, what is the best way to combine the PC_vs_CF.py and PC_vs_CF_singleChannel.py scripts? One uses model trained on both phase and sensor channel and the other use just phase channel.

@ziw-liu
Copy link
Collaborator

ziw-liu commented Sep 18, 2024

what is the best way to combine the PC_vs_CF.py and PC_vs_CF_singleChannel.py scripts? One uses model trained on both phase and sensor channel and the other use just phase channel.

You can put the fluorescence features behind a condition that only executes when there is a second channel.

@ziw-liu
Copy link
Collaborator

ziw-liu commented Sep 24, 2024

@Soorya19Pradeep we decided to not use UMAP for feature correlation. Can you update this PR to reflect that?

@ziw-liu ziw-liu merged commit ad74176 into representation Sep 27, 2024
4 checks passed
@ziw-liu ziw-liu deleted the evaluate_computed_features branch September 27, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working representation Representation learning (SSL)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants