fix: game_outfit custom compatible with canary (familiar, outfit/mount in store) #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
luanluciano93
requested changes
Nov 8, 2024
Co-authored-by: Luan Luciano <[email protected]>
Co-authored-by: Luan Luciano <[email protected]>
kokekanon
changed the title
majestyotbr
changed the title
luanluciano93
requested changes
Jan 22, 2025
| } | ||
| } | ||
|
|
||
| if (g_game.getClientVersion() >= 1281) { | ||
| std::vector<std::tuple<uint16_t, std::string> > familiarList; |
There was a problem hiding this comment.
that is used here
g_game.processOpenOutfitWindow(currentOutfit, outfitList, mountList, **familiarList**, wingList, auraList, effectList, shaderList);if I put it inside the conditional
Severity Code Description Project File Line Suppression State Details
Error (active) E0020 identifier "familiarList" is undefined otclient \src\client\protocolgameparse.cpp 2689
There was a problem hiding this comment.
I wanted to ask why you added the mode to outfits and mounts, and not to family members
There was a problem hiding this comment.
I don't use canary, I don't know many things about familiar, but at the time I test, I didn't see in cipsof that it was used(ui/ux).
could you share a picture of a familiar in cipsoft (outfit) ?
Co-authored-by: Luan Luciano <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: familiar (need test)
8.6 player sorryfeat: Only mine
fix game_outfit : outfit/mount in store
fix: minor error cyclopedia 13.40
feat: server send feature to enable / disable
server:
opentibiabr/canary#3061
commits server :
opentibiabr/canary@74ea55f
Behavior
Actual
Do this and that doesn't happens
Expected
Do this and that happens
Fixes
# (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist