Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: remove bot protection macro #1037

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

nekiro
Copy link
Collaborator

@nekiro nekiro commented Jan 13, 2025

Description

This macro does very poor job at blocking any bot activity and additionally it also blocks some internal lua calls (for example #1028 doesn't work, because of this macro).

It basically just checks the stacktrace of a method and checks if it comes from lua.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@nekiro nekiro changed the title Remove bot protection macro fix: remove bot protection macro Jan 13, 2025
init.lua Show resolved Hide resolved
@kokekanon kokekanon linked an issue Jan 13, 2025 that may be closed by this pull request
5 tasks
@nekiro nekiro force-pushed the remove-bot-protection branch 2 times, most recently from 3d800af to 57903cc Compare January 14, 2025 08:20
@Nottinghster
Copy link
Collaborator

@kokekanon Can you test it?
@nekiro Are we good to go?

@nekiro nekiro force-pushed the remove-bot-protection branch from 72da873 to 8d9d14d Compare January 14, 2025 13:14
@nekiro
Copy link
Collaborator Author

nekiro commented Jan 14, 2025

@kokekanon Can you test it? @nekiro Are we good to go?

From my side, yeah. Rebased with master branch and is good to go.

@kokekanon
Copy link
Collaborator

kokekanon commented Jan 14, 2025

I don't use bot much, but this is important in vbot4.8.

image

https://github.com/mehah/otclient/pull/1037/files#diff-1b975e904a1c9756dc22f83fbc9884012958e3c3f158bc081aaa6c49dfa2f585L806-L815

image

expected result

image

@nekiro
Copy link
Collaborator Author

nekiro commented Jan 14, 2025

I don't use bot much, but this is important in vbot4.8.

Alright, I can add it back.

@mehah mehah changed the title fix: remove bot protection macro improve: remove bot protection macro Jan 14, 2025
@mehah mehah merged commit 262d238 into mehah:main Jan 14, 2025
12 checks passed
@nekiro nekiro deleted the remove-bot-protection branch January 14, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

controller bug bot protected
4 participants