Fix crash when trying to attach a non existing attachedEffect

Reproduction: g_game.getLocalPlayer():attachEffect(g_attachedEffects.getById(9999))
mehah · Nov 13, 2023 · 4a9760f · 4a9760f
1 parent 7da55d9
commit 4a9760f
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/client/thing.cpp b/src/client/thing.cpp
@@ -98,6 +98,9 @@ void Thing::setShader(const std::string_view name) {
 }
 
 void Thing::attachEffect(const AttachedEffectPtr& obj) {
+    if (!obj)
+        return;
+
     if (isCreature()) {
         if (obj->m_thingType && (obj->m_thingType->isCreature() || obj->m_thingType->isMissile()))
             obj->m_direction = static_self_cast<Creature>()->getDirection();