fix: magic effect crash

closes #1085 by removing division by zero scenario
mehah · Jan 28, 2025 · 2f45a1f · 2f45a1f
1 parent 2a0c2a1
commit 2f45a1f
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/client/effect.cpp b/src/client/effect.cpp
@@ -142,9 +142,15 @@ void Effect::setPosition(const Position& position, const uint8_t stackPos, const
         return;
 
     Thing::setPosition(position, stackPos, hasElevation);
+    int pattern_x = getNumPatternX();
+    int pattern_y = getNumPatternY();
+    if (pattern_x == 0 || pattern_y == 0) {
+        g_logger.warning(stdext::format("Failed to send magic effect %d. No sprites declared.", m_clientId));
+        return;
+    }
 
-    m_numPatternX = m_position.x % getNumPatternX();
-    m_numPatternY = m_position.y % getNumPatternY();
+    m_numPatternX = m_position.x % pattern_x;
+    m_numPatternY = m_position.y % pattern_y;
 }
 
 ThingType* Effect::getThingType() const {