ffmpeg-sys: Link EXTRALIBS for component libraries. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done in separate passes to create the most compatible linker order (for each component library first the library name, then its dependencies.) This is necessary for building with the "build" and "build-lib-x264" and/or "build-lib-x265" features enabled, as these libraries are added to "EXTRALIBS-avcodec" in config.mak not "EXTRALIBS". A side effect of this implementation is that libm and libatomic are linked multiple times on Linux as they appear in multiple sub-library link lists, but this seems relatively harmless. Only tested on Linux thus far.
projectgus
force-pushed
the
bugfix/sys_link_libx264_5
branch
from
cf9ed46 to
3e90dc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done in separate passes to create the most compatible linker order (for each component library first the library name, then its dependencies.)
This is necessary for building with the
buildandbuild-lib-x264and/orbuild-lib-x265features enabled. These libraries are added toEXTRALIBS-avcodecin config.mak notEXTRALIBS. i.e.Only tested on Linux.