Fix memory leak (free the descriptor) #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lminiero |
No need, it's a pretty obvious leak, thanks for spotting it! I think it went unnoticed so far because it's basically never used: only the VideoRoom adds a description, but only if a publisher stream has a description, which I think our stock demos never add, and probably not many people using the plugin do either. I'll merge and backport to 0.x. |
lminiero
pushed a commit
that referenced
this pull request
Dec 10, 2024
lminiero
added a commit
that referenced
this pull request
Dec 10, 2024
This reverts commit 932b696, since we actually don't support the description flag in the 0.x recorder.
|
Actually, no change needed in 0.x: there's no description in the recorder there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a memory leak in record.c, here is a small patch.
If someone needs libasan trace log with specific lines that pointed to this descriptor, I can post it here or paste it somewhere (it's a nice 8 lines stacktrace from which you only need 3.5)