Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lua term #3273

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Use lua term #3273

merged 5 commits into from
Oct 2, 2023

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Oct 1, 2023

lminiero
lminiero reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@lminiero lminiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added just a couple of tiny editorial notes.

src/plugins/lua/echotest.lua Outdated Show resolved Hide resolved
src/plugins/lua/echotest.lua Outdated Show resolved Hide resolved
src/plugins/lua/videoroom.lua Outdated Show resolved Hide resolved
@lminiero
Copy link
Member

lminiero commented Oct 2, 2023

Thanks for the quick fixes, merging then!

@lminiero lminiero merged commit ae23fb0 into meetecho:master Oct 2, 2023
lminiero added a commit that referenced this pull request Oct 2, 2023
@lminiero
Replace ansicolors by lua-term (see #3273)
bd9b8e4
@lminiero
Copy link
Member

lminiero commented Oct 2, 2023

I ported the same patch to 0.x too.

@fbrandle fbrandle mentioned this pull request Oct 27, 2023
Closed
@bkmgit bkmgit deleted the use-lua-term branch November 28, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lminiero lminiero lminiero left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkmgit @lminiero