This repository has been archived by the owner on Jan 8, 2019. It is now read-only.
refactor: less file structure and class naming #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkuechler
suggested changes
Jan 5, 2018
src/headline.less
Outdated
| @@ -0,0 +1,51 @@ | |||
| .h1 { | |||
| font-size: 7rem; | |||
| font-weight: @font-medium; | |||
There was a problem hiding this comment.
things like font-weight and color could be moved in to the generic headline styles (line 43)
tilmx
reviewed
Jan 7, 2018
| <meta name="twitter:image" content="https://meetalva.io/images/alva-og_img.png" /> | ||
| <meta name="language" content="en" /> | ||
| <meta name="description" content="Alva is a radically new open source design tool built for cross-functional product teams. You can design with the same components your engineers are using for production." /> | ||
| <meta name="description" content="Alva is a radically new open source design tool built for cross-functional product teams. You can design with the same components your engineers are using for production." | ||
| /> |
There was a problem hiding this comment.
Why is an line break here? (same for the lines above)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.