Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to store an Alegre package for an item of "blank" type. #2214

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Feb 11, 2025

Description

This commit fixes an error reported by Sentry.

Fixes: CV2-6150.

How has this been tested?

TDD. I reproduced it in a unit test that passed after the fix:

$ docker-compose exec api bundle exec ruby test/models/bot/alegre_4_test.rb -n /package/

Error:
Bot::Alegre4Test#test_should_not_try_to_store_package_for_blank_item:
NoMethodError: undefined method `store_package_' for Bot::Alegre:Class
Did you mean?  store_package
               store_package_text

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

This commit fixes an error reported by Sentry.

Fixes: CV2-6150.
@caiosba caiosba requested a review from jayjay-w February 11, 2025 17:21
@caiosba caiosba merged commit 7d18de9 into develop Feb 11, 2025
10 of 11 checks passed
@caiosba caiosba deleted the fix/CV2-6150-store-package-bug branch February 11, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants