Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-6040: Enforce change the status while the report is published #2206

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Feb 6, 2025

Description

Add a flag to enforce change the status while the report is published.

References: CV2-6040

How has this been tested?

Implemented automated tests.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melsawy , is there a way to accomplish that using an attr_accessor?

@melsawy melsawy requested a review from caiosba February 7, 2025 08:03
Copy link

codeclimate bot commented Feb 7, 2025

Code Climate has analyzed commit 0c39fe3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sawy for applying the suggestion from the previous review.

@melsawy melsawy merged commit a6d1a86 into develop Feb 7, 2025
16 checks passed
@melsawy melsawy deleted the CV2-6040-child-doesnt-inherit-rating-from-parent-if-child-has-a-published-report branch February 7, 2025 10:18
melsawy added a commit that referenced this pull request Feb 7, 2025
)

* CV2-6040: add flag to foce status update for item with published report

* CV2-6040: apply PR comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants