CV2-6038 refactor has claim search filter into has article filter #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melsawy
changed the title
…-into-has-article-filter
…-into-has-article-filter
melsawy
commented
Feb 9, 2025
app/models/annotations/embed.rb
Outdated
There was a problem hiding this comment.
I removed the ES callbacks for the title and description since we have already created cached fields for both, and there is an ES callback to synchronize the values.
melsawy
commented
Feb 9, 2025
Comment on lines
-40
to
-45
| def remove_fields_from_elasticsearch_doc(keys, pm_id) | ||
| return if self.disable_es_callbacks || RequestStore.store[:disable_es_callbacks] | ||
| options = { keys: keys, pm_id: pm_id } | ||
| model = { klass: self.class.name, id: self.id } | ||
| ElasticSearchWorker.perform_in(1.second, YAML::dump(model), YAML::dump(options), 'remove_fields') | ||
| end |
There was a problem hiding this comment.
Instead of removing the field from the ES field, I update the value to nil. In the end, both approaches are the same, but I prefer updating the value to nil to be more consistent with other callbacks.
melsawy
requested review from
caiosba,
vasconsaurus and
jayjay-w
as code owners
|
Code Climate has analyzed commit 54a73cf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (100% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
…-into-has-article-filter
caiosba
approved these changes
Feb 10, 2025
melsawy
deleted the
CV2-6038-refactor-has-claim-search-filter-into-has-article-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor has_claim filter to include both FactCheck & Explainer
has_claimfilter tohas_articleReferences: Cv2 6038
How has this been tested?
Implemented automated tests.
Checklist