Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-6125: Fix has_claim filter #2204

Merged

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Feb 5, 2025

Description

The has_claim filter does not function correctly. Users are unable to see items that should be displayed when filtering by "Claim is Empty" so I did the following to fix this issue:

  • Remove ClaimDescription fields from ES when user remove fact-check articles from ProjectMedia
  • Clear ES fact-check fields after remove ClaimDescription from ProjectMediaItem
  • Clear missing codes related to ES comments

References: CV2-6125

How has this been tested?

Implemented automated tests.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

Copy link
Contributor

@caiosba caiosba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Sawy for cleaning some stuff related to comments.

@melsawy melsawy merged commit 968b33d into develop Feb 6, 2025
6 of 7 checks passed
@melsawy melsawy deleted the fix/CV2-6125-has-claim-filter-does-not-work-as-expected branch February 6, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants