Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding social_media value to media type search filter. #2196

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

caiosba
Copy link
Contributor

@caiosba caiosba commented Jan 29, 2025

Description

This new value social_media is basically a shortcut for all the possible social media types.

Reference: CV2-4980.

How has this been tested?

I implemented a unit test for that.

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

This new value `social_media` is basically a shortcut for all the possible social media types.

Reference: CV2-4980.
@caiosba caiosba merged commit bcd39dd into develop Jan 30, 2025
10 of 11 checks passed
@caiosba caiosba deleted the feature/CV2-4980-social-media-search-filter branch January 30, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants