Use Sidekiq.fake instead of Sidekiq.inline by default

[jayjay-w]

Description

Use Sidekiq.fake instead of Sidekiq.inline by default for faster tests

References: CV2-4453

How has this been tested?

Confirmed that all tests pass

Checklist

• I have performed a self-review of my own code
• I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
• I have added regression tests, if the PR fixes a bug
• I have added logging, exception reporting, and custom tracing with any additional information required for debugging
• I considered secure coding practices when writing this code. Any security concerns are noted above.
• I have commented my code in hard-to-understand areas, if any
• I have made needed changes to the README
• My changes generate no new warnings
• If I added a third party module, I included a rationale for doing so and followed our current guidelines

[caiosba]

Thanks Jay, looks like the current PR addresses the first two bullet points we had in the ticket: Add Sidekiq.fake to the Test Helper setup method and add it to test suites that don't use the setup method. As expected, some tests have failed... much less than I expected tbh, so that's good! I assume more changes will be needed to fix the tests that broke. Please ask for a re-review once the tests are fixed. Also, please document in the ticket how long the build takes before and after this change.

[codeclimate]

Code Climate has analyzed commit 959e1e2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.